Single conditional writer for UserFateStore #5670
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids creating multiple conditional writers for UserFateStore. * FateStore now extends AutoCloseable * MetaFateStore.close() falls back to AbstractFateStores impl of close() which is no-op * UserFateStore.close() closes the conditional writer * All tests using a FateStore now call close() * The real fate stores are closed on the shutdown of fate * UserFateStore now only creates a single conditional writer * Num threads for this conditional writer set by a new prop CONDITIONAL_WRITER_THREADS_MAX_FATE_TABLE * writer in UserFateStore is a memoized Supplier so it's not created when using a ReadOnlyFateStore. closes apache#5660
kevinrr888
commented
Jun 20, 2025
Comment on lines
+837
to
+847
| public ConditionalWriter createConditionalWriterForFateTable(String tableName) | ||
| throws TableNotFoundException { | ||
| ConditionalWriterImpl writer = (ConditionalWriterImpl) createConditionalWriter(tableName); | ||
| Integer maxThreads = | ||
| ClientProperty.CONDITIONAL_WRITER_THREADS_MAX_FATE_TABLE.getInteger(getClientProperties()); | ||
| if (maxThreads != null) { | ||
| writer.getConfig().setMaxWriteThreads(maxThreads); | ||
| } | ||
| return writer; | ||
| } | ||
|
|
There was a problem hiding this comment.
we don't want this in public API, so not putting this declaration in AccumuloClient
Comment on lines
+84
to
+87
| CONDITIONAL_WRITER_THREADS_MAX_FATE_TABLE("conditional.writer.threads.max.fate.table", "3", | ||
| PropertyType.COUNT, | ||
| "Maximum number of threads to use for writing data to tablet servers of the FATE system table.", | ||
| "4.0.0", false), |
There was a problem hiding this comment.
What's a good default val for this?
was using try-with-resources on a ReadOnlyFateStore in one place. Reverted the added try-with-resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids creating multiple conditional writers for UserFateStore.
Diff is much larger than actual changes, much of the changes are from needing to put the fate stores in a try-with-resources.
Verified sunny passes and all FATE tests pass
closes #5660