Skip to content

Conversation

Dinesht04
Copy link

fix : #1368

@sy-records sy-records changed the base branch from main to dev October 3, 2025 09:46
@sy-records
Copy link
Member

PRs should be submitted to the dev branch. You can clean up locally and then force push.

@Dinesht04
Copy link
Author

hey @sy-records , could you please review the PR?

Copy link
Member

@shuashuai shuashuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The background color of the pre tag in the design draft is gray-100, so no adjustment should be needed here. It would be more appropriate to adapt the colors for dark mode.

The color matching here is consistent with the background color of the comment area, so go to ui/src/common/color.scss to make a separate adaptation.

eg:
image

Or modify the color of --an-pre in light mode to be consistent with bg-light, and then use --an-pre for the background color of the pre tag.
eg:
image

image

You can choose either of the two methods above.

@Dinesht04
Copy link
Author

@shuashuai thank you for the guidance. I've gone for the route of editing --an-pre's value and using it instead of writing a separate property so that the --an-pre variable could also be used at other places (with the correct color value).

Copy link
Member

@shuashuai shuashuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@shuashuai shuashuai merged commit dc47e1a into apache:dev Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark Mode: Wrong background color for code block

3 participants