fix(forward-auth): extra_headers not resolving variable on $post_arg. #12435
+69
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
dosubot
bot
added
size:L
kayx23
reviewed
Jul 18, 2025
| @@ -187,11 +187,12 @@ curl -X PUT 'http://127.0.0.1:9180/apisix/admin/routes/auth' \ | |||
| "functions": [ | |||
| "return function(conf, ctx) | |||
| local core = require(\"apisix.core\") | |||
| if core.request.header(ctx, \"tenant_id\") then | |||
| local tenant_id = core.request.header(ctx, \"tenant_id\") | |||
| if tenant_id == \"123\" then | |||
| core.response.set_header(\"X-User-ID\", \"i-am-an-user\"); | |||
There was a problem hiding this comment.
Maybe remove this line to avoid any confusion? Since users will not actually observe this response header in this example.
There was a problem hiding this comment.
This is required to pass/deny the request. Users don't need to care about it. This is forward-auth server simulated.
Co-authored-by: Traky Deng <[email protected]>
nic-6443
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing util.resolve_var doesn't handle all the variable cases properly. For eg: when passed with $post_arg.xyz, it fails to resolve the variable. So forward auth plugin is being modified to directly use the ctx.var
And no other plugin using util.resolve_var, tries to resolve $post_arg. so it is assumed that it's not part of the use case for util.resolve_var
This was not caught previously because the test cases didn't assert the values properly.
Checklist