feat(nacos): add metadata filtering support to nacos discovery #12445
Conversation
- Add metadata validation schema in schema_def.lua - Implement metadata filtering logic in nacos discovery - Add comprehensive test cases for metadata validation - Update documentation for metadata filtering feature - Fix lint issues and code formatting
dosubot
bot
added
size:L
|
There seems to be duplicate work #12448 (coincidentally, we have similar demands). According to my understanding of apisix, all routes share the same service discovery results, so it is not suitable to filter in the discovery. |
I don't think it's a duplicate at the moment. Using metadata to filter nacos services is a very useful feature. For more information, you can check the related issue. |
| @@ -54,6 +55,23 @@ local function get_key(namespace_id, group_name, service_name) | |||
| return namespace_id .. '.' .. group_name .. '.' .. service_name | |||
| end | |||
|
|
|||
|
|
|||
| local function metadata_contains(host_metadata, route_metadata) | |||
There was a problem hiding this comment.
Could you explain what these two parameters mean?
|
|
||
|
|
||
|
|
||
| === TEST 28: get APISIX-NACOS info from NACOS - metadata filtering lane=b (only server2) |
There was a problem hiding this comment.
This case is somewhat repetitive, I think the configuration can be changed to
discovery_args:
metadata:
Test the behavior of metadata being empty.
Got it, thanks for you reply :) This is used to filter when pulling the service list from service discovery to avoid pulling a large number of useless instances. We also have similar demands when using Consul. I will try to add the following. |
Description
Add metadata filtering support to nacos discovery.
Which issue(s) this PR fixes:
Fixes #12392
Checklist