-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[WIP] Update backup framework enabled config to global scope #11567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
[WIP] Update backup framework enabled config to global scope #11567
Conversation
@blueorangutan package |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11567 +/- ##
============================================
- Coverage 16.17% 16.17% -0.01%
- Complexity 13294 13296 +2
============================================
Files 5656 5656
Lines 498082 498082
Branches 60415 60414 -1
============================================
- Hits 80569 80568 -1
Misses 408551 408551
- Partials 8962 8963 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove this at line 983. Otherwise backup apis won't show if backup framework is enabled at zone but disabled globally.
if (!BackupFrameworkEnabled.value()) {
return cmdList;
}
2f0ee6d
to
b0b037f
Compare
@blueorangutan package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves the backup framework enabled configuration from zone-scoped to global-scoped, simplifying the backup management by removing per-zone enablement checks. The change affects how the backup framework determines if it's enabled, removing the need to check individual zones.
Key Changes
- Removed zone-specific backup framework configuration support
- Simplified backup enablement logic to use global configuration only
- Updated error messages to reflect global scope
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
api/src/main/java/org/apache/cloudstack/backup/BackupManager.java | Removes zone scope from backup framework configuration key |
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java | Updates backup enablement checks to use global configuration and removes zone-specific logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
Show resolved
Hide resolved
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
Show resolved
Hide resolved
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14918 |
Description
This PR updates backup framework enabled config to global scope (from the existing zone scope).
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?