Skip to content

feat!: support previous non-E2E #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 25, 2025

Motivation and Context

  • Support previous non-E2E design in SDK 35+ (including SDK 36)
  • Add an platform internal plugin called SystemBarPlugin
    • Statusbar (Include auto changing of font/icon color)
    • Nav/Gesture Bar
  • Add Core StatusBar JS APIs

Description

StatusBar JS API:

  • window.statusbar.visible = <true|false>
  • window.statusbar.setBackgroundColor('#AARRGGBB')

`config.xml preferences:

This PR reuses all of the previous preferences. Order of imports listed below

  • For StatusBar
    • StatusBarBackgroundColor
    • BackgroundColor
  • For Nav/Gesture Bar
    • BackgroundColor

Testing

  • npm t
  • Build testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.75%. Comparing base (0190d2e) to head (2fbdc58).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
+ Coverage   72.24%   72.75%   +0.51%     
==========================================
  Files          23       23              
  Lines        1841     1828      -13     
==========================================
  Hits         1330     1330              
+ Misses        511      498      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu erisu added this to the 15.0.0 milestone Jun 25, 2025
@dpogue
Copy link
Member

dpogue commented Jun 27, 2025

You might be able to use @SuppressWarnings("deprecation") to bypass those code scanning warnings about deprecated API

@erisu erisu force-pushed the feat/non-e2e-and-improved-system-bar-theming branch from b4e4b54 to 250a0c6 Compare June 27, 2025 11:19
@erisu erisu changed the title feat!: non-e2e & improved theming feat!: support previous non-E2E Jun 27, 2025
@erisu erisu force-pushed the feat/non-e2e-and-improved-system-bar-theming branch from 250a0c6 to 7859c97 Compare July 7, 2025 13:36
@erisu erisu marked this pull request as ready for review July 7, 2025 14:44
@erisu erisu force-pushed the feat/non-e2e-and-improved-system-bar-theming branch from 56fff49 to 7184110 Compare July 9, 2025 03:24
@erisu erisu requested a review from dpogue July 9, 2025 03:50
@erisu erisu requested a review from dpogue July 9, 2025 05:45
wmathurin added a commit to wmathurin/SalesforceMobileSDK-Package that referenced this pull request Jul 10, 2025
…n Android API 35

Overriding Cordova's default themes for API 35
NB: It looks like better E2E support is coming to Cordova Android 15 - see apache/cordova-android#1817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants