fix(windows): readAsArrayBuffer to use openSequentialReadAsync #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpio
changed the title
|
Restart the tests. |
|
CI: Once more please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
cordova-windows
Motivation and Context
Before this PR, readAsArrayBuffer does not work on windows 10.
This is because xhr fails with empty error.
Indeed some specs in tests fail as
This PR is to fix this issue.
Description
Instead of using
MSApp.createFileFromStorageFile,URL.createObjectURLandXMLHttpRequest, I usedWindows.Storage.Streams.DataReaderwhich is a standard method for reading binary files.Testing
With the help of cordova-mobile-spec, I confirmed all tests pass in cordova-plugin-file-tests.tests on Windows 10 PRO 1809.
Checklist
(platform)if this change only applies to one platform (e.g.(android))