Temporarily fix bug in dynamic top-k optimization #16465
Merged
+43
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
AdamGS
force-pushed
the
adamg/investigate-16452
branch
from
5becc5b to
f915110
Compare
AdamGS
changed the title
adriangb
approved these changes
Jun 19, 2025
|
|
||
| let random_seed = 1u64; // Use a fixed seed to ensure consistent behavior | ||
|
|
||
| println!("Creating test generator with same config as original runner..."); |
There was a problem hiding this comment.
Do you plan on merging the test? If so maybe let's clean this up?
|
Sad to have to do this but I agree keeping CI green is the top priority cc @Dandandan |
alamb
added a commit
to alamb/datafusion
that referenced
this pull request
Jun 22, 2025
…)" This reverts commit 5ca4ff0.
|
We think we have fixed the real cause in Here is a PR to restore the related code in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
See #16452.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?