Skip to content

Pin to pre-release arrow / parquet version 55.2.2 #16492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Pin to pre-release arrow / parquet version 55.2.2 #16492

wants to merge 2 commits into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 20, 2025

Which issue does this PR close?

Rationale for this change

Let's test the new arrow release before we actually release it

What changes are included in this PR?

  1. Update to arrow / parquet 55.2.0

Are these changes tested?

CI

Are there any user-facing changes?

New version of arrow

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Jun 20, 2025
@alamb alamb mentioned this pull request Jun 20, 2025
Closed
8 tasks
@alamb
Copy link
Contributor Author

alamb commented Jun 20, 2025

🤖 ./gh_compare_branch.sh Benchmark Script Running
Linux aal-dev 6.11.0-1015-gcp #15~24.04.1-Ubuntu SMP Thu Apr 24 20:41:05 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/arrow_55.2.0_upgrade (eb6396e) to a4f4b17 diff
Benchmarks: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@alamb
Copy link
Contributor Author

alamb commented Jun 20, 2025

🤖: Benchmark completed

Details 

Comparing HEAD and alamb_arrow_55.2.0_upgrade
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ alamb_arrow_55.2 ┃    Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 0     │  1862.92 ms │       1910.65 ms │ no change │
│ QQuery 1     │   727.71 ms │        701.75 ms │ no change │
│ QQuery 2     │  1407.02 ms │       1347.22 ms │ no change │
│ QQuery 3     │   688.44 ms │        676.64 ms │ no change │
│ QQuery 4     │  1356.05 ms │       1401.85 ms │ no change │
│ QQuery 5     │ 15052.16 ms │      15316.91 ms │ no change │
│ QQuery 6     │  2050.06 ms │       2014.34 ms │ no change │
│ QQuery 7     │  2071.30 ms │       2086.68 ms │ no change │
│ QQuery 8     │   821.77 ms │        833.29 ms │ no change │
└──────────────┴─────────────┴──────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary               ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)               │ 26037.43ms │
│ Total Time (alamb_arrow_55.2)   │ 26289.33ms │
│ Average Time (HEAD)             │  2893.05ms │
│ Average Time (alamb_arrow_55.2) │  2921.04ms │
│ Queries Faster                  │          0 │
│ Queries Slower                  │          0 │
│ Queries with No Change          │          9 │
│ Queries with Failure            │          0 │
└─────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ alamb_arrow_55.2 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.29 ms │          2.28 ms │     no change │
│ QQuery 1     │    34.99 ms │         34.26 ms │     no change │
│ QQuery 2     │    82.56 ms │         81.25 ms │     no change │
│ QQuery 3     │   102.05 ms │         99.76 ms │     no change │
│ QQuery 4     │   587.76 ms │        597.34 ms │     no change │
│ QQuery 5     │   861.80 ms │        854.39 ms │     no change │
│ QQuery 6     │     2.30 ms │          2.26 ms │     no change │
│ QQuery 7     │    38.75 ms │         37.49 ms │     no change │
│ QQuery 8     │   871.68 ms │        867.23 ms │     no change │
│ QQuery 9     │  1174.12 ms │       1195.48 ms │     no change │
│ QQuery 10    │   258.76 ms │        264.29 ms │     no change │
│ QQuery 11    │   292.69 ms │        293.43 ms │     no change │
│ QQuery 12    │   900.75 ms │        889.19 ms │     no change │
│ QQuery 13    │  1285.08 ms │       1254.17 ms │     no change │
│ QQuery 14    │   829.77 ms │        832.96 ms │     no change │
│ QQuery 15    │   794.13 ms │        802.63 ms │     no change │
│ QQuery 16    │  1643.57 ms │       1653.53 ms │     no change │
│ QQuery 17    │  1614.92 ms │       1615.79 ms │     no change │
│ QQuery 18    │  2927.07 ms │       2938.03 ms │     no change │
│ QQuery 19    │    83.54 ms │         85.34 ms │     no change │
│ QQuery 20    │  1156.20 ms │       1132.06 ms │     no change │
│ QQuery 21    │  1328.63 ms │       1260.97 ms │ +1.05x faster │
│ QQuery 22    │  2142.00 ms │       2102.63 ms │     no change │
│ QQuery 23    │  7520.54 ms │       7413.83 ms │     no change │
│ QQuery 24    │   469.30 ms │        455.70 ms │     no change │
│ QQuery 25    │   384.87 ms │        377.51 ms │     no change │
│ QQuery 26    │   522.16 ms │        519.68 ms │     no change │
│ QQuery 27    │  1556.80 ms │       1520.75 ms │     no change │
│ QQuery 28    │ 12814.26 ms │      12941.72 ms │     no change │
│ QQuery 29    │   521.17 ms │        519.38 ms │     no change │
│ QQuery 30    │   773.46 ms │        782.23 ms │     no change │
│ QQuery 31    │   827.56 ms │        819.40 ms │     no change │
│ QQuery 32    │  2479.88 ms │       2520.34 ms │     no change │
│ QQuery 33    │  3217.12 ms │       3164.92 ms │     no change │
│ QQuery 34    │  3255.05 ms │       3163.34 ms │     no change │
│ QQuery 35    │  1282.48 ms │       1264.72 ms │     no change │
│ QQuery 36    │   121.66 ms │        120.81 ms │     no change │
│ QQuery 37    │    52.06 ms │         52.76 ms │     no change │
│ QQuery 38    │   123.23 ms │        117.02 ms │ +1.05x faster │
│ QQuery 39    │   192.69 ms │        192.47 ms │     no change │
│ QQuery 40    │    40.93 ms │         41.50 ms │     no change │
│ QQuery 41    │    38.49 ms │         39.50 ms │     no change │
│ QQuery 42    │    32.92 ms │         33.06 ms │     no change │
└──────────────┴─────────────┴──────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary               ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)               │ 55242.04ms │
│ Total Time (alamb_arrow_55.2)   │ 54957.38ms │
│ Average Time (HEAD)             │  1284.70ms │
│ Average Time (alamb_arrow_55.2) │  1278.08ms │
│ Queries Faster                  │          2 │
│ Queries Slower                  │          0 │
│ Queries with No Change          │         41 │
│ Queries with Failure            │          0 │
└─────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query        ┃      HEAD ┃ alamb_arrow_55.2 ┃    Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 1     │ 102.49 ms │         99.70 ms │ no change │
│ QQuery 2     │  19.86 ms │         20.85 ms │ no change │
│ QQuery 3     │  32.74 ms │         32.86 ms │ no change │
│ QQuery 4     │  18.83 ms │         18.29 ms │ no change │
│ QQuery 5     │  50.04 ms │         49.69 ms │ no change │
│ QQuery 6     │  11.91 ms │         12.09 ms │ no change │
│ QQuery 7     │  88.91 ms │         92.70 ms │ no change │
│ QQuery 8     │  24.58 ms │         25.12 ms │ no change │
│ QQuery 9     │  54.08 ms │         53.52 ms │ no change │
│ QQuery 10    │  43.37 ms │         42.77 ms │ no change │
│ QQuery 11    │  11.42 ms │         11.29 ms │ no change │
│ QQuery 12    │  34.08 ms │         34.82 ms │ no change │
│ QQuery 13    │  26.52 ms │         26.10 ms │ no change │
│ QQuery 14    │   9.81 ms │          9.89 ms │ no change │
│ QQuery 15    │  19.90 ms │         19.02 ms │ no change │
│ QQuery 16    │  18.89 ms │         18.19 ms │ no change │
│ QQuery 17    │  98.02 ms │         95.81 ms │ no change │
│ QQuery 18    │ 197.96 ms │        196.88 ms │ no change │
│ QQuery 19    │  25.38 ms │         25.03 ms │ no change │
│ QQuery 20    │  32.84 ms │         31.91 ms │ no change │
│ QQuery 21    │ 148.02 ms │        145.70 ms │ no change │
│ QQuery 22    │  15.18 ms │         14.81 ms │ no change │
└──────────────┴───────────┴──────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary               ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)               │ 1084.80ms │
│ Total Time (alamb_arrow_55.2)   │ 1077.03ms │
│ Average Time (HEAD)             │   49.31ms │
│ Average Time (alamb_arrow_55.2) │   48.96ms │
│ Queries Faster                  │         0 │
│ Queries Slower                  │         0 │
│ Queries with No Change          │        22 │
│ Queries with Failure            │         0 │
└─────────────────────────────────┴───────────┘

alamb
alamb commented Jun 26, 2025
View reviewed changes
datafusion/sqllogictest/test_files/explain_tree.slt
@@ -280,7 +280,7 @@ physical_plan
06)┌─────────────┴─────────────┐
07)│ DataSourceExec │
08)│ -------------------- │
09)│ bytes: 1072 │
09)│ bytes: 1040 │
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these files are now smaller due to

datafusion/sqllogictest/test_files/repartition_scan.slt
@@ -61,7 +61,7 @@ logical_plan
physical_plan
01)CoalesceBatchesExec: target_batch_size=8192
02)--FilterExec: column1@0 != 42
03)----DataSourceExec: file_groups={4 groups: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:0..137], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:137..274], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:274..411], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:411..547]]}, projection=[column1], file_type=parquet, predicate=column1@0 != 42, pruning_predicate=column1_null_count@2 != row_count@3 AND (column1_min@0 != 42 OR 42 != column1_max@1), required_guarantees=[column1 not in (42)]
03)----DataSourceExec: file_groups={4 groups: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:0..141], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:141..282], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:282..423], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:423..563]]}, projection=[column1], file_type=parquet, predicate=column1@0 != 42, pruning_predicate=column1_null_count@2 != row_count@3 AND (column1_min@0 != 42 OR 42 != column1_max@1), required_guarantees=[column1 not in (42)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files can get larger due to

@alamb alamb mentioned this pull request Jun 26, 2025
Open
@alamb
Copy link
Contributor Author

alamb commented Jun 26, 2025

Superceded by #16575

@alamb alamb closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alamb