[enhance](bdbje)support ssl/tls cert reload #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinchou
reviewed
Sep 26, 2025
src/main/java/com/sleepycat/je/rep/utilint/net/CertificateFileWatcher.java
Outdated
Show resolved
Hide resolved
gavinchou
reviewed
Sep 26, 2025
src/main/java/com/sleepycat/je/rep/utilint/net/SSLChannelFactory.java
Outdated
Show resolved
Hide resolved
gavinchou
reviewed
Sep 26, 2025
| final String pemCa = config.getSSLPemCaCertFile(); | ||
|
|
||
| // Create scheduled executor for periodic certificate checking | ||
| certificateCheckExecutor = Executors.newSingleThreadScheduledExecutor(r -> { |
There was a problem hiding this comment.
是因为要调用 checkAndReloadCertificates 所以不能全局用一个单例来监听文件变更吗?
There was a problem hiding this comment.
RepImpl里只创建一个channelFactory所以只有一个监听线程
gavinchou
approved these changes
Oct 14, 2025
gavinchou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.