Skip to content

[FLINK-37822][tests] Fix flaky test: OpenTelemetryMetricReporterITCase.testReport #26650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Izeren
Copy link

@Izeren Izeren commented Jun 6, 2025

What is the purpose of the change

Address flakiness of the test: OpenTelemetryMetricReporterITCase.testReport

Brief change log

Adding @VisibleForTesting OpenTelemetryMetricReporter#waitForLastReportToComplete method to allow synchronous use of OpenTelemetryMetricReporter#report in tests.

Verifying this change

This change is already covered by existing tests, such as OpenTelemetryMetricReporterITCase.
To ensure it is not flaky, I have run it locally as @RepeatedTest(100) with no issues (previously, fail rate was around 30%).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 6, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants