Skip to content

[FLINK-13230] [pubsub] Add retry mechanism to acknowledging pubsub me… #9388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FLINK-13230] [pubsub] Add retry mechanism to acknowledging pubsub me… #9388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ...n/java/org/apache/flink/streaming/connectors/gcp/pubsub/BlockingGrpcPubSubSubscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,24 @@ public void acknowledge(List<String> acknowledgementIds) {
.addAllAckIds(splittedAckIds.f0)
.build();

stub.withDeadlineAfter(60, SECONDS).acknowledge(acknowledgeRequest);

acknowledgeWithRetries(acknowledgeRequest, retries);
splittedAckIds = splitAckIds(splittedAckIds.f1);
}
}

private void acknowledgeWithRetries(AcknowledgeRequest acknowledgeRequest, int retriesRemaining) {
try {
stub.withDeadlineAfter(timeout.toMillis(), TimeUnit.MILLISECONDS).acknowledge(acknowledgeRequest);
} catch (StatusRuntimeException e) {
if (retriesRemaining > 0) {
acknowledgeWithRetries(acknowledgeRequest, retriesRemaining - 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want to have recursion in the retry logic. Can we replace it with a for loop instead?

return;
}

throw e;
}
}

/* maxPayload is the maximum number of bytes to devote to actual ids in
* acknowledgement or modifyAckDeadline requests. A serialized
* AcknowledgeRequest grpc call has a small constant overhead, plus the size of the
Expand Down