Skip to content

Conversation

@Huginn-kio
Copy link
Contributor

HBASE-29667 Correct block priority to SINGLE on the first write to the bucket cache

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 5m 14s master passed
+1 💚 compile 4m 20s master passed
+1 💚 checkstyle 1m 11s master passed
+1 💚 spotbugs 2m 14s master passed
+1 💚 spotless 1m 5s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 30s the patch passed
+1 💚 compile 4m 14s the patch passed
+1 💚 javac 4m 14s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 12s the patch passed
+1 💚 spotbugs 2m 27s the patch passed
+1 💚 hadoopcheck 14m 0s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 1m 0s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
50m 22s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7399/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7399
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 34682606ed31 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b3a7bd4
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 70 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7399/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and submitting a fix, @Huginn-kio ! It definitely looks like a bug. Can we add a simple UT for this on TestBucketCache? It should simply validate that a BucketEntry gets created with SINGLE priority, then once access() is called, its priority changes to MULTI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants