nimble/host: add support for asynchronous authorization #2013
Conversation
piotrnarajowski
force-pushed
the
authorization
branch
3 times, most recently
from
5552678 to
cacfff5
Compare
piotrnarajowski
force-pushed
the
authorization
branch
from
cacfff5 to
406662a
Compare
piotrnarajowski
force-pushed
the
authorization
branch
from
406662a to
87aa57f
Compare
piotrnarajowski
changed the title
|
#AutoPTS run mynewt GATT/SR/GAR/BI-03-C GATT/SR/GAR/BI-09-C GATT/SR/GAR/BI-15-C GATT/SR/GAR/BI-20-C GATT/SR/GAR/BI-40-C GATT/SR/GAW/BI-04-C GATT/SR/GAW/BI-11-C |
|
Scheduled PR #2013 (comment), board: nrf52, estimated start time: 16:05:06, test case count: 7, estimated duration: 0:14:24 Test cases to be runGATT/SR/GAR/BI-03-CGATT/SR/GAR/BI-09-C GATT/SR/GAR/BI-15-C GATT/SR/GAR/BI-20-C GATT/SR/GAR/BI-40-C GATT/SR/GAW/BI-04-C GATT/SR/GAW/BI-11-C |
|
AutoPTS Bot results: Successful tests (7)GATT GATT/SR/GAR/BI-03-C PASSGATT GATT/SR/GAR/BI-09-C PASS GATT GATT/SR/GAR/BI-15-C PASS GATT GATT/SR/GAR/BI-20-C PASS GATT GATT/SR/GAR/BI-40-C PASS GATT GATT/SR/GAW/BI-04-C PASS GATT GATT/SR/GAW/BI-11-C PASS |
| @@ -471,6 +560,190 @@ ble_att_svr_read_flat(uint16_t conn_handle, | |||
| return rc; | |||
| } | |||
|
|
|||
| int | |||
| ble_att_svr_create_read_rsp(uint16_t conn_handle, uint16_t cid, | |||
There was a problem hiding this comment.
helpers that are not used outside this file should be static and they don't need to be declared in ble_att_priv.h
There was a problem hiding this comment.
But they are used in ble_gatts_pending_req_auth(). Maybe it's confusing because they are in separate commits.
Or did you mean to remove all ble_att_svr_build_foo_rsp from ble_att_priv.h, because these are not used outside ble_att_svr.c file
There was a problem hiding this comment.
OK, removed all unnecessary declarations from ble_att_priv.h and converted them back to static. PTAL
piotrnarajowski
force-pushed
the
authorization
branch
from
87aa57f to
3424aca
Compare
| if (authorized_attrs[i].conn_handle == | ||
| event->authorize.conn_handle && authorized_attrs[i].attr_handle == | ||
| event->authorize.attr_handle) { |
There was a problem hiding this comment.
| if (authorized_attrs[i].conn_handle == | |
| event->authorize.conn_handle && authorized_attrs[i].attr_handle == | |
| event->authorize.attr_handle) { | |
| if (authorized_attrs[i].conn_handle == event->authorize.conn_handle && | |
| authorized_attrs[i].attr_handle == event->authorize.attr_handle) { |
This commit introduces handling authorization in nimble. Each operation on characteristic that has authorize flags will require authorization. Application can respond in GAP authorization event callback with accept, reject or pending response. The latter response should trigger user action to either accept or reject request and finish handling att request. ble_att_svr_create_foo_rsp helpers are introduced to hanldle preparing and sending ATT responses. This is done on top of PR apache#1668 by SumeetSingh19
For authorization testing purposes two characteristics with authorize flags and authorize shell command are added.
BLE_GAP_AUTHORIZE_REJECT is always returned when authorized attribute is being accessed. This is needed for GATT/SR tests that requires rejecting ATT requests with insufficient authorization error.
ble_gatts_pending_req_auth method can be used to prepare and send response to pending ATT request e.g. when user has to authorize operation on attribute that requires authorization
piotrnarajowski
force-pushed
the
authorization
branch
from
3424aca to
6a629f2
Compare
| /* BLE_GATT_READ_MAX_ATTRS * (1 ATT + 1 EATT chan) */ | ||
| #define PENDING_ATTR_MAX MYNEWT_VAL(BLE_GATT_READ_MAX_ATTRS) * 2 | ||
|
|
||
| struct auth_attr { | ||
| uint16_t conn_handle; | ||
| uint16_t attr_handle; | ||
| }; | ||
|
|
||
| extern struct auth_attr authorized_attrs[PENDING_ATTR_MAX]; |
There was a problem hiding this comment.
I am not convinced to this approach. It is because, I'm concerned it won't work as expected to the user. As the authorized_attrs size is limited to PENDING_ATTR_MAX, the authorization state can be lost IMO. I would expect the once authorized client won't be asked for authorization again on attribute access attempt.
The solution that comes to my mind would be a authorization state being stored by user. Meaning the user on authorization required characteristic registration provides authorization state block.
Such block would be flags where each flag would correspond to connection index, so the total number of bits would be BLE_MAX_CONNECTIONS.
This introduces handling authorization in nimble. Each operation on characteristic that has authorize flags will require authorization. Application can respond in GAP authorization event callback with accept, reject or pending response. The latter response should trigger user action to either accept or reject request and finish handling att request
This is done on top of PR #1668 by SumeetSingh19
Fixes GATT/SR/GAW/BI-11-C qualification test case