nimble/ll: Add missing NULL pointer check #2038
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-kaczmarek
requested changes
May 20, 2025
| @@ -920,6 +920,10 @@ ble_ll_sched_rmv_elem_type(uint8_t type, sched_remove_cb_func remove_cb) | |||
| OS_ENTER_CRITICAL(sr); | |||
|
|
|||
| first = TAILQ_FIRST(&g_ble_ll_sched_q); | |||
| if (!first) { | |||
| return; | |||
There was a problem hiding this comment.
OS_EXIT_CRITICAL is missing here
mkasenberg
force-pushed
the
fix-scan-cancel
branch
from
f783be0 to
8cf1a24
Compare
andrzej-kaczmarek
approved these changes
May 21, 2025
Fix potential NULL dereference that occurs when cancelling extended discovery.
mkasenberg
force-pushed
the
fix-scan-cancel
branch
from
8cf1a24 to
eb23027
Compare
|
Force pushed to fix missing commit message |
Comment on lines
928
to
930
| if (first->sched_type == type) { | ||
| first_removed = 1; | ||
| } |
There was a problem hiding this comment.
Please note that this needs to be fixed as well as first_removed can be left uninitialized.
MariuszSkamra
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a segmentation fault that occurred when canceling ext discovery.