Skip to content

[OPENJPA-2937] Merging previously unsaved entity with generated UUID property fixed #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cristof
Copy link
Contributor

@cristof cristof commented Jun 22, 2025

When an entity containing UUID generated fields where merged without being previously persisted, OpenJPA throwed an InternalException because AttachStrategy was not prepared for this type of field.
Added tests for this scenario and for detaching and getReference.

cristof added 2 commits June 22, 2025 16:47
* Updated version number to 4.1.2-SNAPSHOT on pom's and manual.xml
* Fixed merging auto-generated UUID valued entity when it was not previously persisted
* Fixed storage of query when using UUID fields
Copy link
Contributor

@solomax solomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@solomax
Copy link
Contributor

solomax commented Jun 23, 2025

BTW maybe you know what can be wrong with our GH builds? :))

@cristof
Copy link
Contributor Author

cristof commented Jun 24, 2025

I've checked the workflows of the project and found no issues. Tested the project in the same environment (ubuntu-latest with zulu-11 jdk), also passing all green. Activated the same workflow in my openjpa fork - and it also passed (https://github.com/cristof/openjpa/actions/runs/15852928386). Could it be some sort of broken cache?

@solomax
Copy link
Contributor

solomax commented Jun 24, 2025

I've just dropped caches - with no effect :(((

I guess we can @squash and merge" - I'll try to ask ASF INFRA for the help :)

@cristof
Copy link
Contributor Author

cristof commented Jun 24, 2025

Yes, cache clearance didn't work. Who knows. I agree with merging the pending PRs, as compilation and tests are passing in different configurations. It seems to be a github actions issue.

@clambertus
Copy link

Your test database is missing a table: Caused by: org.apache.openjpa.lib.jdbc.ReportingSQLException: Table/View 'OPENJPA_SEQUENCE_TABLE' does not exist. {stmnt 1594403526 DELETE FROM OPENJPA_SEQUENCE_TABLE} [code=30000, state=42X05]

@solomax
Copy link
Contributor

solomax commented Jun 25, 2025

@clambertus All DB tables are being generated during the build.
GH actions build just suddenly stop working.

How can we contact GH support regarding this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants