-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix][sec] Update dependencies to use snakeyaml 2.0 #20222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][sec] Update dependencies to use snakeyaml 2.0 #20222
Conversation
9d88eac
to
91d5210
Compare
b4300fa
to
2772601
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a corner regression by Jackson 2.15. It will affect our json schema. We will need to talk about it this in the dev mail list.
FasterXML/jackson-databind#3874
@codelipenghui @Technoboy- @lhotari @michaeljmarshall @tisonkun would you mind taking a look? |
@mattisonchao So is my understanding correct that wherever UPD: please see 12f5421 |
92dc454
to
12f5421
Compare
Here's the gist, for future discussion, that reproduces regression for regular class, lombok.Data annotated class and lombok.Value annotated class https://gist.github.com/eugene-cheverda/e3370304895ada1048fc210d0261d853 |
Regression changes behavior in the following cases:
@JsonIgnore
private transient String field4;
public String getField4() {
return field4;
}
public void setField4(String field4) {
this.field4 = field4;
}
@JsonIgnore
private transient String field3;
@JsonIgnore
private transient String field4;
public String getField4() {
return field4;
} The most notable discrepancy in behavior between @JsonIgnore
private transient String field3; i.e. for Speaking about usages of
All of the above occurrences are in If this PR gets approved/merged, I'll cherry-pick additional changes into PR agains |
Hi @mattisonchao did you have a chance to discuss this in dev mail group? TIA |
93f03f7
to
ab7cfb9
Compare
ab7cfb9
to
5527996
Compare
I remember that the client doesn't use snakeyaml actually. Maybe you can try exclude the dependency from shaded result so we get rid of all these things. |
The pr had no activity for 30 days, mark with Stale label. |
Resolved by #20085. |
The pr had no activity for 30 days, mark with Stale label. |
already resolved with #20085 |
Fixes #20224
Motivation
Fixes https://avd.aquasec.com/nvd/cve-2022-1471 caused by snakeyaml by updating all dependencies bringing it into the project
Modifications
Updated jackson and prometheus dependencies, updated code to use non-deprecated EnumResolver functions
Verifying this change
This change is already covered by existing tests, such as FieldParserTest.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: eugene-cheverda#1