[feat][broker] add consumer first consume/flow timestamp #24247
Conversation
github-actions
bot
added
the
doc-required
mattisonchao
changed the title
| if (firstConsumedTimestamp == 0) { | ||
| firstConsumedTimestamp = System.currentTimeMillis(); | ||
| } |
There was a problem hiding this comment.
just wondering if this makes sense since flowPermits method would get called before messages get sent to a consumer?
There was a problem hiding this comment.
oh sorry, there are 2 separate fields. Just wondering where lastConsumedTimestamp is set. wouldn't it be set in a similar way as firstConsumedTimestamp?
There was a problem hiding this comment.
oh sorry, there are 2 separate fields. Just wondering where lastConsumedTimestamp is set. wouldn't it be set in a similar way as firstConsumedTimestamp?
IMO, we should also move lastConsumedTimestamp to success sent. That will be more accurate, but I don't want to make this PR more complex. :/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24247 +/- ##
=============================================
- Coverage 73.57% 39.75% -33.83%
+ Complexity 32624 13406 -19218
=============================================
Files 1877 1809 -68
Lines 139502 145485 +5983
Branches 15299 17076 +1777
=============================================
- Hits 102638 57831 -44807
- Misses 28908 80156 +51248
+ Partials 7956 7498 -458
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Motivation
This PR supports two stats for the consumer side to help identify the first message dispatch latency.
Modifications
firstConsumedFlowTimestampfirstConsumedTimestampVerifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete