Skip to content

[fix][client]Failure to load encryption key should not prevent creation of producer on client side #24291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.3
Choose a base branch
from

Conversation

vraulji567
Copy link
Contributor

@vraulji567 vraulji567 commented May 12, 2025

Fixes #24280

Motivation

Failure to load the encryption public key while creating the producer creates a producer on the server side but returns an exception on client side. If the client application is retrying producer creation due to the failure on client side, this will create too many producer connection on the broker side and can bring down the broker.
I expected that the producer creation to be successful (client should not see failure if there is a failure to load the encryption key) and eventually send should fail with the failure to load the encryption key.

Modifications

  • Updated the producer creation to not throw an exception when there is a failure to load the encryption key.

Verifying this change

  • Added tests to verify the change

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 12, 2025
@vraulji567
Copy link
Contributor Author

Can anyone review my PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant