Skip to content

[SPARK-52923][CORE] Allow ShuffleManager to control push merge during shuffle registration #51629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaoyajun02
Copy link
Contributor

@gaoyajun02 gaoyajun02 commented Jul 23, 2025

What changes were proposed in this pull request?

This PR moves the shuffleManager.registerShuffle() call to occur after the initialization of _shuffleMergeAllowed in ShuffleDependency.

Why are the changes needed?

While spark.shuffle.push.enabled provides global control over push-based shuffle, there are scenarios requiring more granular control: 

  • Mass spark application migration scenarios where different jobs may need different shuffle strategies
  • Remote shuffle manager(e.g. celeborn/uniffle) need shuffle-level fallback capabilities to push-based shuffle
  • Dynamic decision making based on shuffle characteristics during shuffle registration

Does this PR introduce any user-facing change?

No, this is an internal refactoring that maintains backward compatibility. The default behavior remains unchanged.

How was this patch tested?

  • Existing unit tests continue to pass
  • The change only affects the order of initialization, not the logic

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the CORE label Jul 23, 2025
@gaoyajun02 gaoyajun02 changed the title [SPARK-52923] Allow ShuffleManager to control push merge during shuffle registration [SPARK-52923][CORE] Allow ShuffleManager to control push merge during shuffle registration Jul 23, 2025
@gaoyajun02
Copy link
Contributor Author

gaoyajun02 commented Jul 23, 2025

cc @Ngone51 @mridulm @LuciferYang PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant