[SPARK-52971] [PYTHON] Limit idle Python worker queue size #51684
+79
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
reviewed
Jul 30, 2025
Comment on lines
107
to
108
| mockWorkers.foreach(_.stop()) | ||
| worker3.stop() |
There was a problem hiding this comment.
Shall we surround the above with try block and put these in the final clause to make sure all the workers are cleaned up?
There was a problem hiding this comment.
Thanks, made this change.
| @@ -33,6 +33,12 @@ import org.apache.spark.util.ThreadUtils | |||
| // Tests for PythonWorkerFactory. | |||
| class PythonWorkerFactorySuite extends SparkFunSuite with SharedSparkContext { | |||
|
|
|||
| private def getIdleWorkerCount(factory: PythonWorkerFactory): Int = { | |||
| val field = factory.getClass.getDeclaredField("idleWorkers") | |||
There was a problem hiding this comment.
I guess it's ok to make idleWorkers as private[spark]? cc @HyukjinKwon
There was a problem hiding this comment.
but let's comment that this exposed for testing purpose.
There was a problem hiding this comment.
Thank you, changed to private[spark] and added comment.
| if (idleWorkerPoolSize.exists(idleWorkers.size > _)) { | ||
| val oldestWorker = idleWorkers.dequeue() | ||
| try { | ||
| oldestWorker.stop() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Makes the number of idle workers in the
PythonWorkerFactorypool configurable.Why are the changes needed?
Without limiting the maximum queue size, the idle worker pool can grow unbounded. Allows better control over number of workers allowed.
Does this PR introduce any user-facing change?
Yes, adds a new optional configuration entry:
spark.python.factory.idleWorkerMaxPoolSize, from Spark 4.1.0How was this patch tested?
This patch adds two new test to verify behavior with and without the worker limit configuration.
Was this patch authored or co-authored using generative AI tooling?
No