Skip to content

[SPARK-52977][TESTS] Fix npm vulnerabilities by npm audit fix #51689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

LuciferYang
Copy link
Contributor

What changes were proposed in this pull request?

This pr fix the following npm vulnerabilities by npm audit fix:

# npm audit report

brace-expansion  1.0.0 - 1.1.11
brace-expansion Regular Expression Denial of Service vulnerability - https://github.com/advisories/GHSA-v6h2-p8h4-qcjw
fix available via `npm audit fix`
node_modules/brace-expansion

form-data  4.0.0 - 4.0.3
Severity: critical
form-data uses unsafe random function in form-data for choosing boundary - https://github.com/advisories/GHSA-fjxv-7rqg-78g4
fix available via `npm audit fix`
node_modules/form-data

2 vulnerabilities (1 low, 1 critical)

To address all issues, run:
  npm audit fix

Why are the changes needed?

Fix npm vulnerabilities

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Actions
  • Locally check:
cd ui-test
npm install --save-dev
node --experimental-vm-modules node_modules/.bin/jest

then

npm install --save-dev

added 340 packages, and audited 341 packages in 3s

38 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
(base) yangjie01@MacBook-Pro ui-test % node --experimental-vm-modules node_modules/.bin/jest
(node:29363) ExperimentalWarning: VM Modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
 PASS  tests/flamegraph.test.js
 PASS  tests/structured-streaming-page.test.js
 PASS  tests/scroll-button.test.js
 PASS  tests/utils.test.js

Test Suites: 4 passed, 4 total
Tests:       10 passed, 10 total
Snapshots:   0 total
Time:        0.508 s, estimated 1 s
Ran all test suites.

Was this patch authored or co-authored using generative AI tooling?

No

@LuciferYang LuciferYang requested a review from yaooqinn July 28, 2025 14:53
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@LuciferYang
Copy link
Contributor Author

Merged into master. Thanks @yaooqinn and @dongjoon-hyun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants