Skip to content

feat(docs): migrate ESLint to v9 #34207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025
Merged

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Jul 17, 2025

feat(docs): migrate ESLint to v9

SUMMARY

Closes #33983

Chore PR to migrate ESLint used in docs project to v9 to keep up with modernity. Built docs are very much still intact

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before and After
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

dependabot bot and others added 3 commits July 4, 2025 00:20
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.8 to 3.6.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.8...3.6.2)

---
updated-dependencies:
- dependency-name: prettier
  dependency-version: 3.6.2
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Jul 17, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
docs/src/theme/Root.js
docs/src/pages/index.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@sadpandajoe sadpandajoe requested review from sfirke and rusackas July 17, 2025 18:14
@rusackas
Copy link
Member

Ooh, cool, thanks!

I think this is our first .mjs file. I haven't looked into it yet, but we might want to take a look at the various eslint configs throughout the repo and make sure we're supporting/linting/testing these files if we want to go down that road.

@hainenber
Copy link
Contributor Author

That's fine, I had reverted to ensure uniformity for ESLint config file across Superset sub-projects :D

@hainenber hainenber merged commit fe1fddd into master Jul 22, 2025
50 checks passed
@hainenber hainenber deleted the feat/migrate-docs-eslint-to-v9 branch July 22, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants