chore(linting): setting no-console to error, and migrating instances to use logging
#34226
+110
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
logging
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/utils/testUtils.ts | ✅ |
| superset-frontend/packages/superset-ui-core/src/translation/TranslatorSingleton.ts | ✅ |
| superset-frontend/src/features/datasets/AddDataset/DatasetPanel/types.ts | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/state.ts | ✅ |
| superset-frontend/src/preamble.ts | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/Modal/FormModal.tsx | ✅ |
| superset-frontend/src/utils/downloadAsImage.ts | ✅ |
| superset-frontend/src/explore/components/Control.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/ThemeEditor/index.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/CodeSyntaxHighlighter/index.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/connection/callApi/callApi.ts | ✅ |
| superset-frontend/src/explore/components/controls/ZoomConfigControl/ZoomConfigControl.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/models/Registry.ts | ✅ |
| superset-frontend/src/dashboard/components/EmbeddedModal/index.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/query/getClientErrorObject.ts | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/utils.ts | ✅ |
| superset-frontend/.eslintrc.js | ✅ |
| superset-frontend/src/explore/components/controls/LayerConfigsControl/LayerConfigsPopoverContent.tsx | ✅ |
| superset-frontend/src/theme/ThemeController.ts | ✅ |
| superset-frontend/src/views/CRUD/hooks.ts | ✅ |
| superset-frontend/src/dashboard/actions/dashboardState.js | ✅ |
| superset-frontend/src/SqlLab/actions/sqlLab.js | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use Claude Code to clean up lint warnings about this particular rule, and enforce it via
error. Now it's set up so that the actual frontend code MUST uselogging(which is safer, and extensible, i.e. we can hotwire it to send a copy of the message to the backend logging service, or... whatever). In tests, the opposite is true. We useconsolerather thanlogging. Also,consoleis allowed in thescriptsfolder, since those are an exception, too.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION