fix: Matching errorType on superset api error with SupersetError #34261
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
api
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/query/types/Query.ts | ✅ |
| superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
justinpark
commented
Jul 21, 2025
| @@ -454,16 +455,14 @@ class DatasourceControl extends PureComponent { | |||
| {isMissingDatasource && !isMissingParams && ( | |||
| <div className="error-alert"> | |||
| {extra?.error ? ( | |||
| <div className="error-alert"> | |||
There was a problem hiding this comment.
removed redundant same error-alert wrapper
| @@ -255,6 +255,7 @@ export type ErrorSource = 'dashboard' | 'explore' | 'sqllab' | 'crud'; | |||
|
|
|||
| export type SupersetError<ExtraType = Record<string, any> | null> = { | |||
| error_type: ErrorType; | |||
| errorType?: ErrorType; | |||
There was a problem hiding this comment.
@justinpark Can't we fix the API responses to use the same field? Having both in the type definition looks really bad and is an indicative that we should fix the APIs.
michael-s-molina
approved these changes
Jul 22, 2025
michael-s-molina
added
the
v5.0
michael-s-molina
pushed a commit
that referenced
this pull request
Jul 23, 2025
) (cherry picked from commit 229d925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For Airbnb, we display custom errors according to the error_type. However, in the current Superset API, unlike the query result API, SupersetApiError is thrown, and error_type is mapped to errorType, which causes custom overrides to not work properly. In this PR, I have resolved the issue by correcting the type of the errorType value.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
locally