WICKET-7159 - Remove isEnabledInHierarchy condition from validate Form #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papegaaij
reviewed
Jun 13, 2025
martin-g
approved these changes
Jun 23, 2025
papegaaij
reviewed
Jun 26, 2025
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
Outdated
Show resolved
Hide resolved
papegaaij
reviewed
Jun 26, 2025
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
Outdated
Show resolved
Hide resolved
|
This pull request looks good to me. When the last comment is addressed, I would like to merge it. |
papegaaij
approved these changes
Jun 26, 2025
|
Thanks @mira-silhavy for the work |
|
Thank you everyone, this issue was causing us pains! Where can I learn about release plans? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/WICKET-7159
Reverting the breaking change introduced in #1033 (comment)
After upgrading to Wicket 10.x, form validators (IFormValidator) are not executed if any dependent form component is disabled, due to the addition of an isEnabledInHierarchy() check. This breaks backward compatibility for applications that rely on validators with conditionally enabled/disabled fields, as the validator is now skipped in these cases. This impacts forms with cross-field validation logic and causes migration issues for existing applications. A flag or configuration to restore the previous behavior, or reverting the change, is needed for backward compatibility