Skip to content

BATIK-1289: batik, xml-apis(-ext) and java modules #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carlosame
Copy link

Remove dependency on xml-apis. The dependency is transitive, and it is causing errors in downstream projects, for example:

[ERROR] the unnamed module reads package org.w3c.dom.css from both xml.apis and jdk.xml.dom

@MariusVolkhart
Copy link

This would also fix https://issues.apache.org/jira/browse/BATIK-1297

@carlosame
Copy link
Author

Hi Marius,

Just a small note: Batik's "old tests" require xml-apis 1.4.01 at runtime. They are run from outside of Maven and manage their own classpath so in principle nothing needs to be done at this pull request, but if somebody wants to integrate those tests with Maven, they will need to add 1.4.01 as a runtime dependency to the old tests, otherwise they are broken.

Anyway, I've basically given up trying to merge stuff here so I did my own fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants