Skip to content

datafile field is necessary if change type is used later. #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

datafile field is necessary if change type is used later. #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SCHEMA.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Now, we will take a look at each attribute associated with a GraphQL type.

`fields`: This is a list of all fields associated with a type. The fields themselves adhere to specific [json-schema](https://github.com/app-sre/qontract-schemas/blob/main/schemas/app-interface/graphql-schemas-1.yml) that we will explore later in this document.

`datafile`: This attribute does not seem to be in used currently.
`datafile`: This is necessary for [App Interface change type](https://gitlab.cee.redhat.com/service/app-interface/-/blob/master/docs/app-sre/change-types.md).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about linking to the change types schema or something that isn't an internal url?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to create description that is more generic and not specifically focused on the use-case?
Change-type is a feature that is implemented in qontract-reconcile and qontract-server should not be aware of features outside of its boundaries. We could very well have other features in q-r that make use of this functionality in future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not related to change-types but to the interfaceResolve strategy schema


`isInterface`: This attribute indicates whether a given type is a GraphQL interface or not. Absence of this field indicate the type assigned is ObjectTypeDefinition.

Expand Down