Generalise ML-DSA with GYB #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this PR. The maintainer of this project is currently out of office so won't get to it for a little while. |
Lukasa
approved these changes
Jun 3, 2025
auto-merge was automatically disabled
June 3, 2025 19:28
Head branch was pushed to by a user without write access
Lukasa
pushed a commit
that referenced
this pull request
Jun 4, 2025
Add ML-DSA-87 ### Checklist - [X] I've run tests to see all new and existing tests pass - [X] I've followed the code style of the rest of the project - [X] I've read the [Contribution Guidelines](CONTRIBUTING.md) - [X] I've updated the documentation if necessary #### If you've made changes to `gyb` files - [X] I've run `.script/generate_boilerplate_files_with_gyb` and included updated generated files in a commit of this pull request ### Motivation: See #355 ### Modifications: Add the "87" parameter set in MLDSA_boring.swift.gyb, add tests for `MLDSA87` and update the test vectors for both ML-DSA 65 and 87 ### Result: `MLDSA87` is now available
glbrntt
added a commit
to glbrntt/swift-crypto
that referenced
this pull request
Jul 21, 2025
This reverts commit 0d32399.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalises the definition of ML-DSA algorithms with GYB to allow the addition of other parameter sets in the future
Checklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
BoringSSL recently made ML-DSA-87 public in its API, in addition to ML-DSA-65 which has already been integrated into Swift Crypto.
By generating the code with GYB we will be able to add support for ML-DSA-87 very easily in the future when the vendored version of BoringSSL is updated.
Modifications:
Generate the code for
MLDSA65(and in future also forMLDSA87) with GYB.Result:
Nothing changes in the public API, but adding
MLDSA87in the future will be instantaneous.