Skip to content
This repository was archived by the owner on Nov 5, 2022. It is now read-only.

Multiple paths For One Server #2

Open
wants to merge 4 commits into
base: multiple-paths
Choose a base branch
from
Open

Multiple paths For One Server #2

wants to merge 4 commits into from

Conversation

lizhengqiang
Copy link

I found the nginx tmpl you supply couldnt handle muilti location in one server.
the new tmpl solved the problem however it use VIRTUAL_PATH env
hope to fix it later

@md5
Copy link
Member

md5 commented Jan 13, 2016

I'm not going to merge this PR in its current form. I think it's important that the upstream nginx.tmpl start using define blocks for common chunks of configuration, so I don't like that those were removed. Besides that, it makes it difficult for me to review what you've actually changed here.

@md5
Copy link
Member

md5 commented Jan 13, 2016

In addition, since @jwilder wants to support this functionality by extending the syntax of the VIRTUAL_HOST variable instead of using a separate VIRTUAL_PATH variable (as discussed in nginx-proxy#254), I'm not keen to spend much time on this branch.

If I do get any time to work on supporting multiple paths in the nginx-proxy image, that time will be spent creating a usable library from docker-gen so that we can use a custom nginx-proxy binary written in Go that can streamline a lot of the nasty template logic in nginx.tmpl. See my (not working) generator branch of docker-gen for where I left off with that work.

@lizhengqiang
Copy link
Author

actually the tpl is comes from another authoer, because it really works, so i think maybe its helpful to the branch, just the branch.
nice
i use traefik for a time, which combine path with host with mux, the regexp follows the host confuse me a lot, which doesnt support ^ \b .etc, the tpl in muiltipath branch has the same problem, so is there any question combing the path & host?
anyway im look forward the new version of nginx-proxy, its amazing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants