Bbrsofiane/maple upgrade #438
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BbrSofiane
force-pushed
the
bbrsofiane/maple-upgrade
branch
from
b6a1e3c to
24835ce
Compare
johnbaldwin
reviewed
Mar 5, 2022
| @@ -8,13 +8,13 @@ | |||
| from django.conf import settings | |||
|
|
|||
|
|
|||
| CELERY_CHECK_MSG_PREFIX = 'figures-devsite-celery-check' | |||
| CELERY_CHECK_MSG_PREFIX = "figures-devsite-celery-check" | |||
There was a problem hiding this comment.
Is there a problem with the single quotes?
There was a problem hiding this comment.
No, I had black enabled at some point. I have disabled it since but looks like I missed some of the changes that were made.
There was a problem hiding this comment.
Thanks. Appreciate that!
|
@BbrSofiane Anything you want help with in the Maple upgrade? |
|
@johnbaldwin I could do with some pointers on how to configure some values like I will have more specific questions once I'm in front of the code. I have some time set aside Wednesday to work on this. |
…-merged John/develop to maple upgrade merged
OmarIthawi
reviewed
Mar 8, 2022
Updatedg Tox to run for Maple only, removing prior Open edX release references, as the Figures Maple support release series makes a clean break from prior Open edX releases * The community tests now run * Also, pytest can run on its own without Tox * The pylint target also now runs and show lint errors * remarked out multisite mode because edx-organizations still requires update * Remarked out edx_lint_check. It fails locally (at least it has always failed locally for me)
Maple upgrade - Tox update + test pruning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Type of change
Related issues
Checklists
Development
Security
Code review