fix:adjust the text wrapping and alignment to ensure it looks good on… #2117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… both mobile and desktop
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-07-24 12:44:09 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-07-24 12:44:10 CET |
ItzNotABug
requested changes
Jul 24, 2025
Comment on lines
198
to
209
| Drag and drop file here or click to <span | ||
| style="display: inline-flex; align-items: center; gap: 0.25em;"> | ||
| upload | ||
| <Tooltip> | ||
| <Layout.Stack | ||
| alignItems="center" | ||
| justifyContent="center" | ||
| inline> | ||
| <span style="display: inline-flex; align-items: center;"> | ||
| <Icon icon={IconInfo} size="s" /> | ||
| </Layout.Stack> | ||
| <svelte:fragment slot="tooltip" | ||
| >Only .tar.gz files allowed</svelte:fragment> | ||
| </span> | ||
| <svelte:fragment slot="tooltip"> | ||
| Only .tar.gz files allowed | ||
| </svelte:fragment> | ||
| </Tooltip> | ||
| </Layout.Stack> | ||
| {#if maxSize > 0} | ||
| <Typography.Caption variant="400" | ||
| >Max file size: {readableMaxSize.value + | ||
| readableMaxSize.unit}</Typography.Caption> | ||
| {/if} | ||
| </Layout.Stack> | ||
| </span> |
There was a problem hiding this comment.
we still don't need this span. <Typography.Text> should properly handle what we need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI Enhancement: Function Upload Dialog Text Alignment
Improved text alignment and responsiveness in the function upload dialog:
Before:
Text and icon were misaligned with inconsistent spacing.
After:
Clean, centered layout with proper text wrapping and icon placement.