feat: added implementation to send mail using python #31
Conversation
|
Thanks @anushkrishnav! @christyjacob4 can you please review it? |
Glide7
requested review from
TorstenDittmann and
christyjacob4
and removed request for
TorstenDittmann
| from dotenv import load_dotenv | ||
|
|
||
| load_dotenv() |
There was a problem hiding this comment.
We wont be needing this once we upload the cloud function.
| certifi==2020.12.5 | ||
| chardet==4.0.0 | ||
| idna==2.10 | ||
| python-dotenv==0.15.0 |
There was a problem hiding this comment.
This can be removed as well
|
|
||
| ``` | ||
|
|
||
| * Ensure that your folder structure looks like this |
There was a problem hiding this comment.
Please refer to the readme here
https://github.com/appwrite/demos-for-functions/tree/master/python/object-detection
We need the dependencies to be installed in the .appwrite folder
Secondly it's missing the instructions to create a tarfile
|
@anushkrishnav Hey, did you see these reviews? :) |
Co-authored-by: Christy Jacob <[email protected]>
|
@Glide7 @christyjacob4 can this be merged? |
|
@eldadfux It doesn't look like all the review comments have been addressed. |
|
I am looking into it tonight been a bit busy |
|
Thanks @anushkrishnav 🙏🏻 |
|
@anushkrishnav will you be taking a look at these? |
|
Yes I will be , right now I have some research work going on so not able to commit |
|
@anushkrishnav would you still like to complete this PR? |
|
Yeh will push the commits tonight |
Now we can send mail using Mailgun API and Python :)
referring Issue #19