Skip to content

Fix the global.process issue in TcpSocket.js while preserving debugging #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

eventengineering
Copy link

@eventengineering eventengineering commented Oct 3, 2019

Fix the global.process issue in TcpSocket.js while preserving ability to debug with Chrome/vscode.
Overwrites global.process in TcpSocket.js only when one of the following is true:

global.process does not exist
global.process does exist and global.process.nextTick does not exist.

Port of PeelTechnologies#89

Fix the global.process issue in TcpSocket.js while preserving ability to debug with Chrome/vscode.
Overwrites global.process in TcpSocket.js only when one of the following is true:

global.process does not exist
global.process does exist and global.process.nextTick does not exist.
Copy link
Collaborator

@phillbaker phillbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@phillbaker phillbaker merged commit 0d38301 into aprock:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants