Correct Ethernet.begin() #3764
Closed
Correct Ethernet.begin() #3764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct inizialization of Ethernet.begin() is: - Ethernet.begin(mac); - Ethernet.begin(mac, ip); - Ethernet.begin(mac, ip, dns); - Ethernet.begin(mac, ip, dns, gateway); - Ethernet.begin(mac, ip, dns, gateway, subnet); Ethernet.begin(mac, ip, gateway, subnet); is a common mistake. --> https://www.arduino.cc/en/Reference/EthernetBegin Will need to change the examples in the Reference.
|
Would it be clearer to have two vars, Alternatively, you could add a comment making note that the Gateway is the DNS resolver in this case. |
|
Like this? #3728. |
|
Yes, I think that's a good example. |
|
I've merged the changes in #3728 that are slightly more clear. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct inizialization of Ethernet.begin() is:
Ethernet.begin(mac, ip, gateway, subnet); is a common mistake.
--> https://www.arduino.cc/en/Reference/EthernetBegin
Will need to change the examples in the Reference.