Skip to content

Fix crash due to index json parse errors and permission problems #7964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 3, 2018

See #7937

@cmaglie cmaglie added this to the Release 1.8.7 milestone Sep 3, 2018
Copy link
Contributor

@PaulStoffregen PaulStoffregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good: The IDE is able to start up after I change the first character in library_index.json from '{' to '<'.

Good: Opening the Library Manager causes library_index.json to be updated.

Not so good: After updating library_index.json, the library manager window remains blank. It does display properly if I close and reopen the library manager window.

I tested with arduino-PR-7964-BUILD-769 on Linux 64 bit.

@PaulStoffregen
Copy link
Contributor

Here's the library manager window after it has replaced library_index.json with a good copy.

librarymanager

The library list actually has been updated, but a user looking only at the GUI and not the file in the hidden folder would believe it didn't do anything.

@cmaglie
Copy link
Member Author

cmaglie commented Sep 3, 2018

Yes, it has to re-open the window, I'm trying to fix this.

@cmaglie cmaglie force-pushed the fix-json-errors-and-permission-problems branch from 424fde0 to c45c1af Compare September 5, 2018 16:15
@arduino arduino deleted a comment from ArduinoBot Sep 5, 2018
@cmaglie
Copy link
Member Author

cmaglie commented Sep 5, 2018

Pushed other two commits, should fix it for good

Copy link
Contributor

@PaulStoffregen PaulStoffregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with PR-7964-BUILD-771, the GUI is properly updating. Looks great!

@cmaglie cmaglie merged commit ddbe80b into arduino:master Sep 6, 2018
@cmaglie cmaglie deleted the fix-json-errors-and-permission-problems branch September 6, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants