Skip to content

[breaking] Rename telemetry to metrics #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2021
Merged

[breaking] Rename telemetry to metrics #1108

merged 1 commit into from
Jan 8, 2021

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Dec 14, 2020 •
edited by per1234
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Changes all occurences of the term telemetry to metrics.

  • What is the current behavior?

No behaviour changed.

  • What is the new behavior?

Same as before.

Yes, the UPGRADING.md file has been updated accordingly.

  • Other information:

None.

Related

Keywords

  • prometheus

@silvanocerza silvanocerza added topic: documentation Related to documentation for the project component/CLI labels Dec 14, 2020
@silvanocerza silvanocerza requested a review from rsora December 14, 2020 16:34
@silvanocerza silvanocerza self-assigned this Dec 14, 2020
@silvanocerza silvanocerza force-pushed the scerza/metrics-settings branch from 474da43 to b54ae84 Compare December 14, 2020 16:39
@silvanocerza silvanocerza requested a review from alranel December 15, 2020 10:44
@silvanocerza silvanocerza merged commit d8fc095 into master Jan 8, 2021
@silvanocerza silvanocerza deleted the scerza/metrics-settings branch January 8, 2021 17:07
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself and removed topic: documentation Related to documentation for the project labels Jun 7, 2022
@per1234 per1234 mentioned this pull request Oct 22, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alranel alranel Awaiting requested review from alranel

1 more reviewer

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@silvanocerza silvanocerza

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silvanocerza @rsora @per1234