Skip to content

chore: Add the version of the Argo CD dependency to version output #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

jannfis
Copy link
Collaborator

@jannfis jannfis commented Jun 24, 2025

What does this PR do / why we need it:

This adds the version of the Argo CD dependency that the agent has been built against to the version output.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Checklist

  • Documentation update is required by this PR (and has been updated) OR no documentation update is required.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.00%. Comparing base (3346a14) to head (3c616d4).

Files with missing lines Patch % Lines
internal/version/version.go 61.11% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   46.94%   47.00%   +0.06%     
==========================================
  Files          84       84              
  Lines        8772     8784      +12     
==========================================
+ Hits         4118     4129      +11     
+ Misses       4313     4311       -2     
- Partials      341      344       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

$ ./dist/argocd-agentctl version
{"name":"argocd-agent","component":"ctl","version":"0.0.1-alpha","gitRevision":"3c616d4b7d1c11cb7d803e583bc98bdb884de70e","gitStatus":"unknown","goVersion":"go1.24.2","buildDate":"2025-06-25T17:45:15+05:30","argocdVersion":"v2.14.13"}

@jannfis jannfis merged commit 4a306b0 into main Jun 25, 2025
16 checks passed
@jannfis jannfis deleted the chore/argocd-version branch June 25, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants