fix: use registry for helm registry .. commands
#23142
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
3 tasks
For OCI Helm repositories that require credentials, `helm registry login` and `helm registry logout` needs to use the registry host, rather than the full repository url. The issue is that if an app has a `repoURL` that contains more than a host, e.g `registry-1.docker.io/bitnamicharts`, the full repo url gets passed to `helm registry ..` rather than just the hostname. Using a repository credential with just the host doesn't help either, since that doesn't get matched to the `repoURL`, hence the creds don't get passed along to the repo server. This notably affects Dockerhub, since pretty much any chart that's hosted privately will have this issue. Fixes argoproj#22831. Signed-off-by: Blake Pettersson <[email protected]>
blakepettersson
force-pushed
the
fix/ensure-oci-registry-login-always-uses-registry-host
branch
from
aaf3fdc to
0a0b85a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23142 +/- ##
=========================================
Coverage ? 60.08%
=========================================
Files ? 343
Lines ? 57904
Branches ? 0
=========================================
Hits ? 34790
Misses ? 20335
Partials ? 2779 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OCI Helm repositories that require credentials,
helm registry loginandhelm registry logoutneeds to use the registry host, rather than the full repository url. The issue is that if an app has arepoURLthat contains more than a host, e.gregistry-1.docker.io/bitnamicharts, the full repo url gets passed tohelm registry ..rather than just the hostname.Using a repository credential with just the host doesn't help either, since that doesn't get matched to the
repoURL, hence the creds don't get passed along to the repo server.This
notably affectsseems to affect only Dockerhub (I haven't yet tried Harbor, but Quay seems to work without issue even with the fullrepoURL), since pretty much any chart that's hosted privately will have this issue. Fixes #22831.Checklist: