Skip to content

feat(ui): Add option to disable animations #23143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielJiang378
Copy link

@DanielJiang378 DanielJiang378 commented May 25, 2025

related to 5982

If a user has reduce motion set up on their computer this css class will automatically remove the animation css from the 3 specific animated classes .icon.spin status-icon--spin and fa-spin.

Within the issue it was noted that we should add a toggle to allow the user to also decide within the app to disable and enable animations. However if we were to store this information within ViewPreferences similar to pref.theme we would need to drill the prop extremely deep to reach the SpinningIcon class.

Since this is my first contribution I don't want to make a large architectural change such as adding Context to the entire UI to allow for this drilling of props. So for now I've created a "partial" fix that gives developers the functionality to save some resources if needed

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • [] My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@DanielJiang378 DanielJiang378 requested a review from a team as a code owner May 25, 2025 23:09
Copy link

bunnyshell bot commented May 25, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
@DanielJiang378 DanielJiang378 force-pushed the add-reduce-motion-support branch from bd5b38b to c04c60c Compare May 25, 2025 23:10
@crenshaw-dev crenshaw-dev changed the title feat:Add option to disable animations feat(ui): Add option to disable animations May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant