fix(appset): progressive sync loop when applciation has sync errors

[agaudreault]

Actual PR on master #23187

• When an application is stuck in OutOfSync due to sync failures or misconfigured ignoredDifferences, etc. then only sync it once. If it has been synced at least once for the targetRevision and it is still OutOfSync, mmove it to Progressing and wait for a manual/magical intervention. User can/should configure sync retry on their applications.
• When an application can reconcile, but has invalid conditions, set it to progressing until a manual intervention happen.
• When an application cannot reconcile, usually it is because of an InvalidSpec/project/namespace configuration, then it is not considered as a valid app and it is left in pending until the errors are resolved and can reconcile.
• Remove the documented feature that application are move automatically to Healthy becasue the code does not exist for that.
• Sort ApplicationStatus by application name so it is consistent
• Sort the conditions by type so it is consistent
• Do not remove the Progressive Sync conditions when the Application is configured for progressive sync.
• Add info logs for all progressive sync transitions

[codecov]

Codecov Report

Attention: Patch coverage is 78.73754% with 64 lines in your changes missing coverage. Please review.

Project coverage is 55.96%. Comparing base (5c24b6b) to head (1d23403).

Files with missing lines	Patch %	Lines
...cationset/controllers/applicationset_controller.go	79.85%	54 Missing and 2 partials ⚠️
.../apis/application/v1alpha1/applicationset_types.go	65.21%	6 Missing and 2 partials ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release-3.0   #23186      +/-   ##
===============================================
+ Coverage        55.89%   55.96%   +0.06%     
===============================================
  Files              343      343              
  Lines            57395    57446      +51     
===============================================
+ Hits             32080    32148      +68     
+ Misses           22669    22649      -20     
- Partials          2646     2649       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.