Use pattern as domain separator #63
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
reviewed
Jun 18, 2025
| Hierarchy::Begin => stack.push((position, interaction)), | ||
| Hierarchy::End => { | ||
| let Some((position, begin)) = stack.pop() else { | ||
| dbg!(); |
There was a problem hiding this comment.
Suggested change
| dbg!(); |
tcoratger
reviewed
Jun 19, 2025
| label: Label, | ||
| /// The Rust name of the type of the value. | ||
| /// | ||
| /// We use [`core::any::type_name`] to verify value types intead of [`core::any::TypeID`] since |
There was a problem hiding this comment.
Suggested change
| /// We use [`core::any::type_name`] to verify value types intead of [`core::any::TypeID`] since | |
| /// We use [`core::any::type_name`] to verify value types instead of [`core::any::TypeID`] since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #62 and makes minimal diff replacement of
DomainSeparator. Some of the functionalitypatternprovides is not used but will be used in an refactored/extended API. It's also awkwardly explicit in creating the patterns for testing, this will be fixed in a follow up refactoring PR.Work in progress tests are not yet adapted.