-
-
Couldn't load subscription status.
- Fork 458
Add daily warning message about ArviZ's refactoring #2485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Now that I am seeing this. Do we want to include this in the next release or first make a release without warnings yet but including the fix for i/o, attrs in idata/datatree conversion... then make a follow up release to add the warning? I think the next release is the one that will allow proper migration through the On the other hand, if we add a pin for the "loud" version of arviz in downstream dependencies like pymc then downstream libraries will know to migrate but users won't which is also not a good development |
| today = datetime.date.today() | ||
|
|
||
| if stamp_file.exists(): | ||
| last_date = datetime.date.fromisoformat(stamp_file.read_text().strip()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about read_text and write_text!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aloctavodia approved after you apply @OriolAbril's suggestion
Co-authored-by: Oriol Abril-Pla <[email protected]>
|
We should have a migration plan. That may be something like
We may want to have some tentative dates for these steps, even if vague and subject to change. We may want to add more steps, too. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
==========================================
- Coverage 86.83% 86.82% -0.01%
==========================================
Files 124 124
Lines 13018 13035 +17
==========================================
+ Hits 11304 11318 +14
- Misses 1714 1717 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📚 Documentation preview 📚: https://arviz--2485.org.readthedocs.build/en/2485/