Add ingest_spectra function #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't pass tests until https://github.com/astrodbtoolkit/astrodb-template-db/pull/160/files is merged. |
There was a problem hiding this comment.
Pull Request Overview
This PR moves the ingest_spectrum functionality from SIMPLE into the astrodb_utils package and enhances spectrum ingestion error handling. Key changes include:
- Updates to tests for handling regime matching and ingestion error scenarios.
- New utility function check_obs_date and updates to get_db_regime for improved regime matching.
- Implementation of ingest_spectrum in spectra.py with integration of spectrum validation and database operations.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_utils.py | Updated tests for get_db_regime with caplog support for warning checks |
| tests/test_spectra.py | Added tests for ingest_spectrum, including error and success cases |
| pyproject.toml | Updated dependency version for "ads" |
| astrodb_utils/utils.py | Added check_obs_date and improved regime matching logic |
| astrodb_utils/spectra.py | Added ingest_spectrum function and integrated spectrum accessibility |
| astrodb-template-db | Updated subproject reference |
| .github/workflows/run_tests.yml | Modified linter command options |
|
I don't love this function -- it does a LOT of things. But it works, and we need it. Please review @dr-rodriguez and/or @canavarrete01 . |
dr-rodriguez
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingest_spectrum function moved from SIMPLE.