Skip to content

Conversation

smcguire-cmu
Copy link
Contributor

Fixes #880

Copy link

github-actions bot commented Oct 6, 2025

Before [5fe1775] After [a4ffc50] Ratio Benchmark (Parameter)
25.6±0.6ms failed n/a benchmarks.time_box_filter_on_partition
5.90±0.01s failed n/a benchmarks.time_create_large_catalog
877±10ms failed n/a benchmarks.time_create_midsize_catalog
90.7±0.6ms failed n/a benchmarks.time_kdtree_crossmatch
failed failed n/a benchmarks.time_open_many_columns_all
40.4±0.7ms failed n/a benchmarks.time_polygon_search
578±5ms 581±6ms 1.01 benchmarks.time_open_many_columns_list
1.69±0.05s 1.64±0.01s 0.97 benchmarks.time_open_many_columns_default

Some benchmarks failed or their performance regressed significantly.

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.34%. Comparing base (5fe1775) to head (09ec5e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1065   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files          46       46           
  Lines        2634     2641    +7     
=======================================
+ Hits         2564     2571    +7     
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Oct 6, 2025

Before [5fe1775] After [d518c8c] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_open_many_columns_all
25.5±0.4ms 25.7±0.2ms 1.01 benchmarks.time_box_filter_on_partition
5.77±0.02s 5.82±0.02s 1.01 benchmarks.time_create_large_catalog
864±5ms 869±6ms 1.01 benchmarks.time_create_midsize_catalog
90.6±0.6ms 91.2±1ms 1.01 benchmarks.time_kdtree_crossmatch
575±5ms 576±2ms 1.00 benchmarks.time_open_many_columns_list
1.65±0.02s 1.64±0.01s 0.99 benchmarks.time_open_many_columns_default
40.8±0.5ms 40.2±0.5ms 0.99 benchmarks.time_polygon_search

Some benchmarks failed or their performance regressed significantly.

Copy link

github-actions bot commented Oct 7, 2025

Before [5fe1775] After [2af9fb4] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_open_many_columns_all
26.1±0.7ms 26.8±1ms 1.03 benchmarks.time_box_filter_on_partition
5.82±0.03s 5.92±0.02s 1.02 benchmarks.time_create_large_catalog
880±9ms 880±5ms 1.00 benchmarks.time_create_midsize_catalog
93.6±3ms 94.0±0.8ms 1.00 benchmarks.time_kdtree_crossmatch
1.78±0.01s 1.76±0.01s 0.99 benchmarks.time_open_many_columns_default
591±8ms 580±6ms 0.98 benchmarks.time_open_many_columns_list
42.6±0.9ms 41.6±2ms 0.98 benchmarks.time_polygon_search

Some benchmarks failed or their performance regressed significantly.

Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The tests are failing but I think the fix for those is incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Loading a Catalog's Default Columns + [requested column]
2 participants