Skip to content

Conversation

dougbrn
Copy link
Contributor

@dougbrn dougbrn commented Oct 6, 2025

Resolves #1046

Larger PR, but that's partly due to some copy-pasted functions/docstrings

  • Direct renaming changes
  • Scrub LSDB code of underlying usage of deprecated nested-pandas function names
  • Reduce->map_rows, implementing map_rows wrapper and deprecating reduce

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.82%. Comparing base (ded5f0b) to head (d6cfe60).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
- Coverage   97.15%   96.82%   -0.33%     
==========================================
  Files          46       46              
  Lines        2741     2776      +35     
==========================================
+ Hits         2663     2688      +25     
- Misses         78       88      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Oct 6, 2025

Before [5fe1775] After [e1f5aaa] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_open_many_columns_all
1.73±0.05s 1.80±0.01s 1.04 benchmarks.time_open_many_columns_default
99.2±1ms 99.0±0.9ms 1.00 benchmarks.time_kdtree_crossmatch
620±6ms 617±8ms 1.00 benchmarks.time_open_many_columns_list
29.2±2ms 28.8±1ms 0.99 benchmarks.time_box_filter_on_partition
6.02±0.05s 5.98±0.01s 0.99 benchmarks.time_create_large_catalog
906±8ms 898±8ms 0.99 benchmarks.time_create_midsize_catalog
44.8±2ms 44.5±0.6ms 0.99 benchmarks.time_polygon_search

Some benchmarks failed or their performance regressed significantly.

Copy link

github-actions bot commented Oct 7, 2025

Before [5fe1775] After [2b38f38] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_open_many_columns_all
40.4±1ms 42.8±2ms 1.06 benchmarks.time_polygon_search
92.5±1ms 97.5±2ms 1.05 benchmarks.time_kdtree_crossmatch
1.64±0.01s 1.70±0.06s 1.04 benchmarks.time_open_many_columns_default
5.85±0.01s 5.92±0.04s 1.01 benchmarks.time_create_large_catalog
588±8ms 592±10ms 1.01 benchmarks.time_open_many_columns_list
25.4±0.9ms 25.4±0.4ms 1.00 benchmarks.time_box_filter_on_partition
884±9ms 887±8ms 1.00 benchmarks.time_create_midsize_catalog

Some benchmarks failed or their performance regressed significantly.

Copy link

Before [ded5f0b] After [6fd6033] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_lazy_crossmatch_many_columns_all_suffixes
failed failed n/a benchmarks.time_lazy_crossmatch_many_columns_overlapping_suffixes
failed failed n/a benchmarks.time_open_many_columns_all
26.1±0.1ms 27.4±1ms 1.05 benchmarks.time_box_filter_on_partition
91.0±1ms 93.3±1ms 1.02 benchmarks.time_kdtree_crossmatch
1.70±0.07s 1.71±0.06s 1.01 benchmarks.time_open_many_columns_default
578±10ms 576±4ms 1.00 benchmarks.time_open_many_columns_list
5.82±0.06s 5.79±0.03s 0.99 benchmarks.time_create_large_catalog
879±10ms 869±6ms 0.99 benchmarks.time_create_midsize_catalog
44.1±2ms 40.3±0.5ms 0.91 benchmarks.time_polygon_search

Some benchmarks failed or their performance regressed significantly.

Copy link

Before [ded5f0b] After [471752d] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_lazy_crossmatch_many_columns_all_suffixes
failed failed n/a benchmarks.time_lazy_crossmatch_many_columns_overlapping_suffixes
failed failed n/a benchmarks.time_open_many_columns_all
5.83±0.06s 5.90±0.04s 1.01 benchmarks.time_create_large_catalog
887±20ms 888±10ms 1.00 benchmarks.time_create_midsize_catalog
1.71±0.06s 1.69±0.06s 0.99 benchmarks.time_open_many_columns_default
583±8ms 577±4ms 0.99 benchmarks.time_open_many_columns_list
41.6±0.9ms 40.9±0.5ms 0.98 benchmarks.time_polygon_search
93.1±2ms 90.4±0.9ms 0.97 benchmarks.time_kdtree_crossmatch
27.5±1ms 25.5±0.08ms 0.93 benchmarks.time_box_filter_on_partition

Some benchmarks failed or their performance regressed significantly.

@dougbrn dougbrn changed the title Nested-Pandas v0.6 Compatibility Nested-Pandas v0.6 Compatibility + map_rows implementation Oct 14, 2025
@dougbrn dougbrn requested a review from delucchi-cmu October 14, 2025 22:06
@dougbrn dougbrn marked this pull request as ready for review October 14, 2025 22:06
Copy link

Before [ded5f0b] After [b724a9c] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_lazy_crossmatch_many_columns_all_suffixes
failed failed n/a benchmarks.time_lazy_crossmatch_many_columns_overlapping_suffixes
failed failed n/a benchmarks.time_open_many_columns_all
1.63±0.01s 1.65±0.01s 1.01 benchmarks.time_open_many_columns_default
41.7±0.7ms 42.2±0.6ms 1.01 benchmarks.time_polygon_search
26.0±0.2ms 26.0±0.1ms 1.00 benchmarks.time_box_filter_on_partition
92.1±0.6ms 91.9±1ms 1.00 benchmarks.time_kdtree_crossmatch
5.88±0.02s 5.83±0.04s 0.99 benchmarks.time_create_large_catalog
885±3ms 879±10ms 0.99 benchmarks.time_create_midsize_catalog
585±2ms 582±0.7ms 0.99 benchmarks.time_open_many_columns_list

Some benchmarks failed or their performance regressed significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Nested-Pandas >=0.6

1 participant