Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This adds type hints and fixes #592.
For astropy quantities, I used
Quantity
without any physical type or units annotations. The reasons are:Union
with non-Quantity types (seeunits.quantity_input
with annotatedQuantity
type hint in aUnion
causes error astropy#17017)The tests are all passing on my machine.
I was not sure what the formatting guidelines were for this package. Let me know if there are issues on that side!