Expand the supported data types for filter values in Mast.mast_query
#3422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3422 +/- ##
==========================================
+ Coverage 70.54% 70.57% +0.02%
==========================================
Files 232 232
Lines 20022 20037 +15
==========================================
+ Hits 14125 14141 +16
+ Misses 5897 5896 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
snbianco
force-pushed
the
mast-query-list
branch
from
ba29e41 to
81160bf
Compare
snbianco
changed the title
Mast.mast_query
bsipocz
reviewed
Oct 17, 2025
| ---------- | ||
| key : str | ||
| Parameter name (used for error messages). | ||
| val : any |
There was a problem hiding this comment.
nitpick: general guideline to always spell out names, we don't need to save characters
Comment on lines
-1178
to
+1238
| warnings.warn("'columns' parameter will not mask non-filtered services", InputWarning) | ||
| warnings.warn( | ||
| "'columns' parameter is ignored for non-filtered services.", | ||
| InputWarning | ||
| ) |
There was a problem hiding this comment.
no need to change it back but in general we allow longer lines (120), so no need to cut up perfectly valid one liners
| """ | ||
| # Range filters must be dicts with 'min' and 'max' | ||
| if isinstance(val, dict): | ||
| if not {"min", "max"}.issubset(val.keys()): |
There was a problem hiding this comment.
What happens when value has more than min/max, would the server handle dropping/using the extra ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for filters not related to position or request in
Mast.mast_query, users had to enclose filter values in a list for the expected response from the server. This PR handles the following cases so that filters are passed in correctly:I also added more documentation, since this was unclear to users before.