-
Notifications
You must be signed in to change notification settings - Fork 478
Fix path to install script in README.md #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdated documentation changes download URLs in README files to reference Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (4)
install/README.md (2)
6-13
: Harden one-liners: fail-fast on HTTP errors and pipeline failures.
- Add -f to curl so 404/5xx don’t get piped to bash.
- Prefer curl variant, or wrap wget with pipefail to avoid false success when wget fails.
Apply:
-curl -sSL https://raw.githubusercontent.com/automazeio/ccpm/main/install/ccpm.sh | bash +curl -fsSL https://raw.githubusercontent.com/automazeio/ccpm/main/install/ccpm.sh | bashOptional (if keeping wget):
-wget -qO- https://raw.githubusercontent.com/automazeio/ccpm/main/install/ccpm.sh | bash +# Less preferred: ensure pipeline fails if wget fails +bash -c 'set -o pipefail; wget -qO- https://raw.githubusercontent.com/automazeio/ccpm/main/install/ccpm.sh | bash'
15-25
: Consider pinning installs to a tag for reproducibility.Document an alternative that references a released tag instead of main to avoid drift.
Example:
curl -fsSL https://raw.githubusercontent.com/automazeio/ccpm/vX.Y.Z/install/ccpm.sh | bash
README.md (2)
391-393
: Path update is correct; mirror curl hardening.Approve the install/ccpm.sh path. Also add -f to curl (and same note about wget/pipefail if you show wget elsewhere) to fail fast on HTTP errors.
Apply:
- curl -sSL https://raw.githubusercontent.com/automazeio/ccpm/main/install/ccpm.sh | bash + curl -fsSL https://raw.githubusercontent.com/automazeio/ccpm/main/install/ccpm.sh | bash - # or: wget -qO- https://raw.githubusercontent.com/automazeio/ccpm/main/install/ccpm.sh | bash + # or (ensure pipeline fails if download fails): + # bash -c 'set -o pipefail; wget -qO- https://raw.githubusercontent.com/automazeio/ccpm/main/install/ccpm.sh | bash'
395-403
: Optional: add pinned-tag variant and checksum note.For deterministic installs, show a tag-pinned command and (optionally) a shasum verify step.
Example:
# Pin to a release tag curl -fsSL https://raw.githubusercontent.com/automazeio/ccpm/vX.Y.Z/install/ccpm.sh | bash # Optional integrity check # curl -fsSL https://github.com/automazeio/ccpm/releases/download/vX.Y.Z/ccpm.sh.sha256 -o ccpm.sh.sha256 # curl -fsSL https://raw.githubusercontent.com/automazeio/ccpm/vX.Y.Z/install/ccpm.sh -o ccpm.sh # shasum -a 256 -c ccpm.sh.sha256 && bash ccpm.sh
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
README.md
(1 hunks)install/README.md
(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-28T00:16:38.208Z
Learnt from: gsornsen
PR: automazeio/ccpm#545
File: .github/workflows/release-test.yml:54-65
Timestamp: 2025-08-28T00:16:38.208Z
Learning: In gsornsen's CCPM project, the GitHub Actions workflows deliberately install Git Bash and Chocolatey on Windows runners to normalize shell commands across all platforms (Windows, macOS, Linux), creating a unified bash environment that works consistently across the OS matrix.
Applied to files:
README.md
install/README.md
📚 Learning: 2025-08-28T00:18:18.000Z
Learnt from: gsornsen
PR: automazeio/ccpm#545
File: Makefile:175-175
Timestamp: 2025-08-28T00:18:18.000Z
Learning: In gsornsen's CCPM project, they prefer to ignore native Windows cmd.exe compatibility issues (like mkdir -p) in favor of their Git Bash approach that normalizes shell commands across all platforms, creating a unified bash environment.
Applied to files:
README.md
🔇 Additional comments (1)
install/README.md (1)
6-6
: Path fix is correct.install/ccpm.sh is the right target after the move. Looks good.
Also applies to: 12-12
3bff66d
to
f48ed35
Compare
This PR corrects the installation script path in documentation to point to the correct location in the repository.
Changes:
The install script was moved to the install/ directory but the documentation still referenced the old root location, causing 404 errors for users trying to install via the provided commands.
Summary by CodeRabbit