-
Notifications
You must be signed in to change notification settings - Fork 2
Add S3 compatibility docs #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for autonomysdevdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small suggestions. Content looks great!
// No actual S3 bucket is created - it's just URL routing | ||
``` | ||
|
||
- Base URL: http://localhost:3000/s3 (development) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I think that we should add the mainnet & testnet URL instead of dev that would be rarely used
Mainnet: https://public.auto-drive.autonomys.xyz/api/s3
Taurus: https://public.taurus.auto-drive.autonomys.xyz/api/s3
pages/sdk/auto-drive/s3_layer.mdx
Outdated
|
||
// Step 2: Upload parts | ||
const uploadPartCommand = new UploadPartCommand({ | ||
Bucket: "http://localhost:3000/s3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to be used mainnet endpoints for examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, good suggestion 👍
Co-authored-by: Jim Counter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds a dedicated page on S3 compatibility and includes everything from the overview to the migration guide.
Based on the @clostao draft.